LogData nullable spanId, traceId #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
requested review from
anuraaga,
bogdandrutu,
carlosalberto,
jkwatson and
jsuereth
as code owners
jack-berg
commented
Oct 14, 2021
| } | ||
|
|
||
| @Test | ||
| void toProtoLogRecord_MinimalFields() { |
There was a problem hiding this comment.
This test fails without the updates to the marshaler.
Codecov Report
@@ Coverage Diff @@
## main #3745 +/- ##
============================================
+ Coverage 89.18% 89.30% +0.11%
- Complexity 3870 3875 +5
============================================
Files 463 463
Lines 12125 12123 -2
Branches 1188 1188
============================================
+ Hits 10814 10826 +12
+ Misses 916 908 -8
+ Partials 395 389 -6
Continue to review full report at Codecov.
|
This was referenced Dec 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was working on a prototype Log4j2 appender, and noticed that protobuf marshaling fails if spanId / traceId are left to their default blank values.
I've updated
LogDatato reflect that spanId and traceId are optional, and updated the marshaler to work with nullable values.Will likely to make other fields on
LogDatanullable as well.